Fix Acceptance tests #504
Merged
Fix Acceptance tests #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welandaz
commented
Nov 19, 2024
| import spock.lang.Subject | ||
|
|
||
| import java.nio.charset.StandardCharsets | ||
|
|
||
| class DevelocityExceptionLogProcessorTest extends Specification { | ||
| class DevelocityExceptionLogProcessorTest extends BaseJenkinsIntegrationTest { |
There was a problem hiding this comment.
Switching to Integration test to not depend on Jenkins implementation
welandaz
commented
Nov 19, 2024
| @@ -30,7 +30,7 @@ class BuildScanInjectionGradleIntegrationTest extends BaseGradleIntegrationTest | |||
|
|
|||
| private static final String MSG_INIT_SCRIPT_APPLIED = "Connection to Develocity: http://foo.com" | |||
|
|
|||
| private static final List<String> GRADLE_VERSIONS = ['4.10.3', '5.6.4', '6.9.4', '7.6.4', '8.9'] | |||
There was a problem hiding this comment.
Version removed as it fails both locally and on CI due to JDK 17 and Groovy version we use compatibility
alextu
approved these changes
Nov 19, 2024
|
LGTM but I don't see green acceptance tests for this branch 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several things: