Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GradleConsoleAnnotator when Timestamper is globally enabled #374

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

alextu
Copy link
Contributor

@alextu alextu commented Dec 11, 2023

Fixes JENKINS-72411 by detecting the timestamp prefix and shift the Gradle notes.
It should always be a complete timestamp and its format should not change (afaik it's changed by a formatter later on when displaying the console).

Testing done

  • Unit test for detecting the timestamp prefix
  • Integration test to check the expected Gradle notes. The left menu could not be part of this test as it's loaded separately with an ajax request. I checked it manually though.

Submitter checklist

Preview Give feedback

@alextu alextu requested a review from welandaz December 11, 2023 14:05
@alextu alextu self-assigned this Dec 11, 2023
@alextu alextu requested a review from welandaz December 14, 2023 15:48
@alextu alextu merged commit 1ce458b into master Dec 15, 2023
10 checks passed
@alextu alextu deleted the atual/fix-gradle-annotator branch December 15, 2023 13:36
@alextu alextu added the bugfix label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants