-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-75011] Use Apache Mina as ssh transport layer, remove trilead #1022
Merged
fcojfernandez
merged 20 commits into
jenkinsci:master
from
jmdesprez:JENKINS-75011-apache-mina-ssh
Jan 22, 2025
Merged
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
92c7809
Use Apache Mina as ssh transport layer, remove trilead
jmdesprez f7deaff
NullPointerException prevention
jmdesprez 4549402
Spotbugs fix
jmdesprez 3b52047
Null pointer prevention
jmdesprez bcfbd7c
Add a timestamp to the SCP
jmdesprez 8225f35
Make remoting.jar readable for everyone
jmdesprez bda7f3c
Refactor PEMParser to KeyHelper
jmdesprez 471b5d0
Fix ServerKeyVerifier implementation
jmdesprez 9f45558
Fix hudson-run-init verification
jmdesprez 480c37f
Replace try-with-resource by manual close. Use the timeout from the n…
jmdesprez 243088d
Use dedicated client for the remoting jar
jmdesprez 0726489
Merge branch 'master' into JENKINS-75011-apache-mina-ssh
jmdesprez 7680d4e
Use timeout from the node
jmdesprez fe9a901
Improve code readability
jmdesprez 9abf818
NullPointerException prevention
jmdesprez 9a4fc3b
Extract Corretto URL
jmdesprez 7ceaeea
Add debug log when the command fails
jmdesprez 4e9d26d
Rewrite generatePublicKeyFromPrivateKey
jmdesprez 7b68bae
Fix getSshAlgorithm when Bouncy Castle is used
jmdesprez abea87f
Move timeout initialization after checking the node
jmdesprez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
530 changes: 328 additions & 202 deletions
530
src/main/java/hudson/plugins/ec2/ssh/EC2MacLauncher.java
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: make the constant all-caps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to publish the comment until it was marked as ready for review, I am still learning GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem 🙂
This should use the timeout from the node anyway: 7680d4e