Extract inline onClick handler (#306)

jenkinsci · Dec 20, 2024 · d69d4cf · d69d4cf
1 parent 0920d8b
commit d69d4cf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/main/resources/io/jenkins/plugins/DingTalkRobotConfig/config.jelly b/src/main/resources/io/jenkins/plugins/DingTalkRobotConfig/config.jelly
@@ -42,6 +42,7 @@
       </f:entry>
     </j:scope>
 
+    <st:adjunct includes="io.jenkins.plugins.DingTalkRobotConfig.validate-robot-config-onclick"/>
     <div class="robot-config-validate-msg"><!-- this is where the error message goes --></div>
     <div style="text-align: right;">
       <input
@@ -51,7 +52,6 @@
         data-validate-button-descriptor-url="${descriptor.descriptorFullUrl}"
         data-validate-button-method="test"
         data-validate-button-with="${with}"
-        onclick="validateRobotConfig(this)"
       />
     </div>
   </div>

diff --git a/src/main/resources/io/jenkins/plugins/DingTalkRobotConfig/validate-robot-config-onclick.js b/src/main/resources/io/jenkins/plugins/DingTalkRobotConfig/validate-robot-config-onclick.js
@@ -0,0 +1,5 @@
+Behaviour.specify('.robot-config-validate-btn', 'validate-robot-config', 0, function(element) {
+    element.addEventListener('click', function() {
+        validateRobotConfig(this);
+    });
+});