Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Java 17 and 2.475; adapt test suite to EE 9 #182

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

basil
Copy link
Member

@basil basil commented Aug 29, 2024

Subsumes #181. Allow this plugin's test suite to be exercised regularly in Plugin Compatibility Tester (PCT) in https://github.com/jenkinsci/bom by requiring Java 17 or newer and Jenkins 2.475 (released today) or newer.

This PR goes against the usual advice from https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ by requiring a weekly release. The advantage is that this will allow plugin compatibility testing (PCT). The disadvantage is that new features and bug fixes can't be released to LTS users for another few months.

The choice is up to the maintainer as to whether or not to accept this PR. If this PR is rejected, we will stop testing this plugin in PCT.

@basil basil force-pushed the jakarta branch 2 times, most recently from 4b30813 to 2ac5231 Compare September 4, 2024 14:05
@basil basil changed the title Adapt to EE 9 Adapt test suite to EE 9 Sep 4, 2024
@basil basil marked this pull request as ready for review September 4, 2024 14:18
@basil basil changed the title Adapt test suite to EE 9 Require Java 17 and 2.475; adapt test suite to EE 9 Sep 4, 2024
@basil basil requested a review from rsandell September 4, 2024 14:31
@basil
Copy link
Member Author

basil commented Oct 12, 2024

Should fix JENKINS-73903, I think.

@basil basil requested a review from a team October 17, 2024 20:04
@TWestling
Copy link
Member

@basil
Regarding the dependency on a weekly release: Is the reason that we don't have an LTS with the requirements on Spring 6 and EE 9, and that we can go back to LTS depedency later on, once it is stabilized?

@basil
Copy link
Member Author

basil commented Oct 20, 2024

@TWestling Yes exactly. When 2.479.1 LTS is released on October 30, I will file another PR in this repository to move back to the LTS line.

@TWestling TWestling merged commit 8e26516 into jenkinsci:master Oct 23, 2024
13 checks passed
@basil
Copy link
Member Author

basil commented Oct 23, 2024

Thanks @TWestling! Could this please be released? That way, users will be able to upgrade to 2.479.1 LTS next week with a fully working set of plugins.

@TWestling
Copy link
Member

@basil My plan was to release it now, thought I'd try it out first, and when running hpi:run, I get:
java.lang.ClassNotFoundException: jakarta.servlet.ServletContextListener

Any idea why? Running on Maven 3.9.8 and JDK 17.

@TWestling
Copy link
Member

Managed to test this in a roundabout way, so the plugin is now released.
Still need some help on running hpi:run with the jakarta changes though, thankful for any help.

@basil
Copy link
Member Author

basil commented Oct 25, 2024

I will file a PR next Wednesday when 2.479.1 is released that will clean up the parent POM, switch back to LTS, and restore hpi:run. Thanks for your patience as we go through this rough migration.

@TWestling
Copy link
Member

No worries, just glad that it seems you know what the issue is :)
Got nowhere in trying to deduce the problem on my own.

@basil
Copy link
Member Author

basil commented Oct 30, 2024

I will file a PR next Wednesday when 2.479.1 is released that will clean up the parent POM, switch back to LTS, and restore hpi:run.

Done in #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants