Avoid using a temporary file to store screenshot after a test failure #1855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary files are created with permissions
600
, differing from defined umask. For the screenshot file that is later attached as diagnostic, this can cause permission issues in some environments.Tested by arbitrary failing a test and checking permissions set on resulting
screenshot.png
that can be found undertarget/diagnostics/{testName}/screenshot.png
.In my case
644
instead of600
.Testing done
Submitter checklist