Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Transcoding #358

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor Transcoding #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a26de5
Refactor play_utils.py
Shadowghost Dec 27, 2024
dca2735
Enforce transcoding width
Shadowghost Dec 27, 2024
0e6c96b
Fix bitrate selection on transcode
Shadowghost Dec 27, 2024
938756a
Remove non-existing fields
Shadowghost Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions resources/lib/dialogs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ class BitrateDialog(xbmcgui.WindowXMLDialog):

slider_control = None
bitrate_label = None
initial_bitrate_value = 0
initial_bitrate_value = 500
max_bitrate_value = 15000
min_bitrate_value = 500
step_size = 100
selected_transcode_value = 0

def __init__(self, *args, **kwargs):
Expand All @@ -23,10 +26,11 @@ def __init__(self, *args, **kwargs):

def onInit(self):
log.debug("ActionMenu: onInit")
log.debug("ActionMenu: max: {} - min: {}, init: {}".format(self.max_bitrate_value, self.min_bitrate_value, self.initial_bitrate_value))
self.action_exitkeys_id = [10, 13]

self.slider_control = self.getControl(3000)
self.slider_control.setInt(self.initial_bitrate_value, 400, 100, 15000)
self.slider_control.setInt(self.initial_bitrate_value, self.min_bitrate_value, self.step_size, self.max_bitrate_value)

self.bitrate_label = self.getControl(3030)
bitrate_label_string = str(self.slider_control.getInt()) + " Kbs"
Expand Down
8 changes: 4 additions & 4 deletions resources/lib/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

from .jellyfin import api
from .utils import (
translate_string, get_version, load_user_details, get_art_url,
get_bitrate, translate_string, get_version, load_user_details, get_art_url,
get_default_filters, translate_path, kodi_version, get_jellyfin_url
)
from .kodi_utils import HomeWindow
Expand Down Expand Up @@ -536,12 +536,12 @@ def show_menu(params):
elif selected_action == "transcode":
params['force_transcode'] = 'true'

max_bitrate = settings.getSetting("force_max_stream_bitrate")
initial_bitrate_value = int(max_bitrate)
max_bitrate = int(get_bitrate(settings.getSetting("force_max_stream_bitrate")) / 1000)
bitrate_dialog = BitrateDialog(
"BitrateDialog.xml", PLUGINPATH, "default", "720p"
)
bitrate_dialog.initial_bitrate_value = initial_bitrate_value
bitrate_dialog.max_bitrate_value = max_bitrate
bitrate_dialog.initial_bitrate_value = max_bitrate
bitrate_dialog.doModal()
selected_transcode_value = bitrate_dialog.selected_transcode_value
del bitrate_dialog
Expand Down
Loading
Loading