Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow to validate composer dependencies #2905

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

pifou25
Copy link
Contributor

@pifou25 pifou25 commented Sep 21, 2024

Description

repris de mon autre PR sur composer, ce workflow permet de valider les dépendances de Composer à la fois pour php7.4 et 8.2 il rajoute 2 checks:
image
j'ai ajouté les contraintes platform & require php:7.4 et maj le composer.lock en conséquence.

Suggested changelog entry

Github workflow de validation des dépendances Composer php7.4 et 8.2

Related issues/external references

Fixes #

Types of changes

  • Bug fix (non-breaking change which fixes)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement
  • ci/cd improvement

PR checklist

@pifou25 pifou25 force-pushed the feat/validate_composer branch 3 times, most recently from 2544e0f to 2d6f4ef Compare September 21, 2024 23:04
@zoic21
Copy link
Contributor

zoic21 commented Sep 22, 2024

Bonjour,
Par contre la c'est le meme composer.lock qu'on soit en php 7 ou 8 ?

@pifou25
Copy link
Contributor Author

pifou25 commented Sep 22, 2024

oui c'est le même et on s'assure qu'il est valide pour les 2 versions.

@pifou25 pifou25 force-pushed the feat/validate_composer branch from 2d6f4ef to 3883f55 Compare November 29, 2024 15:57
@pifou25
Copy link
Contributor Author

pifou25 commented Dec 8, 2024

J'ai fait un rebase sur cette branche, il reste quelques changements, en plus du workflow de validation: la gestion du composer.lock en particulier, il est versionné (plus présent dans .gitignore) et donc on ne le supprime pas puisque c'est la référence pour l'installation.

@pifou25 pifou25 mentioned this pull request Dec 17, 2024
11 tasks
add php:7.4 as required and min platform
update composer.lock
@pifou25 pifou25 force-pushed the feat/validate_composer branch from cc65035 to da9075f Compare January 5, 2025 16:58
@pifou25
Copy link
Contributor Author

pifou25 commented Jan 5, 2025

J'ai rebase la branche. Suite au rebase on a cette erreur sur le workflow de validation de composer:

Verifying lock file contents can be installed on current platform.
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run composer update or composer update <package name>.

  • Required package "influxdata/influxdb-php" is not present in the lock file.

C'est normal, lorsqu'on modifie composer.json il faut également modifier composer.lock, je lance donc en local composer update, et la, autre erreur:

Updating dependencies
Your requirements could not be resolved to an installable set of packages.

Problem 1
- Root composer.json requires influxdata/influxdb-php, it could not be found in any version, there may be a typo in the package name.

Je remplace influxdata/influxdb-php (qui n'existe pas c'est influxdb/influxdb-php ) par influxdata/influxdb-client-php qui est le bon je suppose :)

@zoic21 zoic21 merged commit db0a7de into jeedom:alpha Jan 11, 2025
6 checks passed
@pifou25 pifou25 deleted the feat/validate_composer branch January 11, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants