Allow the RedisDriver to launch a Redis Cluster. #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey folks, dogpile.cache / sqlalchemy here, is pifpaf still being maintained? this is a pretty simple PR and it's kind of blocking us on merging a new feature with tests. if pifpaf is no longer maintained we'd need to start devising alternatives |
|
@zzzeek it's slightly maintained, I think the main issue here is that the CI did not run and I'm not even sure CI is still working TBH. |
|
@jd you're here! thanks so much, I know all about "slightly maintained" and that's fine :) yah the PR here looks a little bigger than I thought |
|
I have no time to work on this sadly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
RedisDriverdidn't have the ability to launch a 3 node HA Redis Cluster.This PR ain to add this functionality.
Note that Sentinel and Cluster are exclusive. This is reflected in the code.