Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7-improve-startup-performance #205

Merged
merged 4 commits into from
Jan 10, 2025
Merged

7-improve-startup-performance #205

merged 4 commits into from
Jan 10, 2025

Conversation

hexiaofeng
Copy link
Collaborator

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in joylive-demo project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@hexiaofeng hexiaofeng linked an issue Jan 10, 2025 that may be closed by this pull request
Improve startup performance #7
Closed
@hexiaofeng hexiaofeng requested a review from chenzhiguo January 10, 2025 05:33
@hexiaofeng hexiaofeng self-assigned this Jan 10, 2025
@hexiaofeng hexiaofeng added the enhancement New feature or request label Jan 10, 2025
chenzhiguo
chenzhiguo approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@chenzhiguo chenzhiguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenzhiguo chenzhiguo merged commit 4e10ce8 into main Jan 10, 2025
1 check passed
@chenzhiguo chenzhiguo deleted the 7-improve-startup-performance branch January 10, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenzhiguo chenzhiguo chenzhiguo approved these changes

Assignees

@hexiaofeng hexiaofeng

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve startup performance
2 participants
@hexiaofeng @chenzhiguo