Un-hose javadoc links (and fix warnings). Fixes #663.

jchambers · Feb 23, 2020 · 42b3dae · 42b3dae
1 parent 96fe955
commit 42b3dae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -201,7 +201,7 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-javadoc-plugin</artifactId>
-                    <version>3.0.1</version>
+                    <version>3.1.1</version>
                     <configuration>
                         <source>7</source>
                     </configuration>

diff --git a/pushy/pom.xml b/pushy/pom.xml
@@ -122,7 +122,7 @@
                     <links>
                         <link>https://docs.oracle.com/javase/8/docs/api/</link>
                         <link>https://netty.io/4.1/api/</link>
-                        <link>https://google.github.io/gson/apidocs/</link>
+                        <link>https://www.javadoc.io/doc/com.google.code.gson/gson/2.8.0/</link>
                     </links>
                 </configuration>
             </plugin>

diff --git a/pushy/src/main/java/com/turo/pushy/apns/util/SimpleApnsPushNotification.java b/pushy/src/main/java/com/turo/pushy/apns/util/SimpleApnsPushNotification.java
@@ -117,7 +117,7 @@ public SimpleApnsPushNotification(final String token, final String topic, final
      * @param pushType the type of notification to be sent
      * @param priority the priority with which this notification should be delivered to the receiving device
      */
-    public SimpleApnsPushNotification(final String token, final String topic, final String payload, final Date invalidationTime, final DeliveryPriority priority, PushType pushType) {
+    public SimpleApnsPushNotification(final String token, final String topic, final String payload, final Date invalidationTime, final DeliveryPriority priority, final PushType pushType) {
         this(token, topic, payload, invalidationTime, priority, pushType, null, null);
     }
 
@@ -148,6 +148,7 @@ public SimpleApnsPushNotification(final String token, final String topic, final
      * @param invalidationTime the time at which Apple's servers should stop trying to deliver this message; if
      * {@code null}, no delivery attempts beyond the first will be made
      * @param priority the priority with which this notification should be delivered to the receiving device
+     * @param pushType the type of notification to be sent
      * @param collapseId the "collapse identifier" for this notification, which allows it to supersede or be superseded
      * by other notifications with the same collapse identifier
      */