Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

翻訳: /themes/basics/post-types.md, the-loop.md, template-tags.md #20

Merged
merged 40 commits into from
Sep 27, 2023
Merged

翻訳: /themes/basics/post-types.md, the-loop.md, template-tags.md #20

merged 40 commits into from
Sep 27, 2023

Conversation

mkismy
Copy link
Contributor

@mkismy mkismy commented Sep 15, 2023

Close #19

t-hamano
t-hamano reviewed Sep 17, 2023
View reviewed changes
Copy link
Member

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありがとうございます🙏

おそらくtextlintでチェックしていただいており、非常に自然な翻訳だと感じましたので、全体的に全く問題ないと思いました。

好みによるところもあるかもしれませんが、細かい点をコメントさせていただきました。サジェストコメントは、問題無い場合そのままサジェストコミットしていただいて構いません（スカッシュマージで、メインブランチには1コミットでマージするため）

theme/basics/post-types.md Outdated Show resolved Hide resolved
theme/basics/post-types.md Outdated Show resolved Hide resolved
theme/basics/post-types.md Outdated Show resolved Hide resolved
theme/basics/post-types.md Outdated Show resolved Hide resolved
theme/basics/post-types.md Outdated Show resolved Hide resolved
theme/basics/the-loop.md Outdated Show resolved Hide resolved
theme/basics/the-loop.md Outdated Show resolved Hide resolved
theme/basics/the-loop.md Show resolved Hide resolved
theme/basics/the-loop.md Outdated Show resolved Hide resolved
theme/basics/the-loop.md Outdated Show resolved Hide resolved
@t-hamano t-hamano mentioned this pull request Sep 25, 2023
Open
96 tasks
mkismy and others added 24 commits September 27, 2023 15:42
@mkismy @t-hamano
Update theme/basics/post-types.md
0ba861f 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
d9d53d8 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
320874e 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
c412495 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
997783e 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
9b87092 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
2f4c3f3 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
11e3f14 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
62c5349 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
0ba03f2 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
ab261cf 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
d65b1de 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
8550244 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
851625e 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
80048cd 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
d4fb1eb 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/template-tags.md
8190f9c 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/post-types.md
2d53e80 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/template-tags.md
b3489ee 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/template-tags.md
c1a5735 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/template-tags.md
6b1b554 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/template-tags.md
1ac302b 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/template-tags.md
62bbc4d 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
f696505 
Co-authored-by: Aki Hamano <[email protected]>
mkismy and others added 13 commits September 27, 2023 15:51
@mkismy @t-hamano
Update theme/basics/the-loop.md
085697c 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
82f2166 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
2efa677 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
52fffbe 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
6b8c6e1 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
a1265b2 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
447b7d1 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
45c44d6 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
cfd5132 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
9ec23b1 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
5047095 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy @t-hamano
Update theme/basics/the-loop.md
6ac6152 
Co-authored-by: Aki Hamano <[email protected]>
@mkismy
Update translation
dc1e676
@mkismy
Copy link
Contributor Author

mkismy commented Sep 27, 2023

遅ればせながら翻訳漏れの追加とsuggestionのコミットを行いました 🙇 @t-hamano

@t-hamano
Copy link
Member

ご対応ありがとうございます！こちらでマージしますね。

なお把握出来ていなかったのですが、こちらのコメントにある通り、テーマハンドブックのオーバーホールが行われようとしているそうです。セクションがかなり変わってしまうので、これからの新規翻訳は念のため控えておいてよいかな。。と思っています。

翻訳に関しては他にも沢山コントリビュート出来るものがあると思いますので、もしよろしければSlackの #docsチャンネルで聞かれてみるのもよいかもしれません 🙏

@t-hamano t-hamano self-requested a review September 27, 2023 13:35
@t-hamano t-hamano merged commit 0b66e6d into jawordpressorg:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

Assignees

@mkismy mkismy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

翻訳: /themes/basics/post-types.md, the-loop.md, template-tags.md
2 participants
@mkismy @t-hamano