-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ns 7.0 compatibility #7
base: master
Are you sure you want to change the base?
Conversation
@Upd4ting Thank you very much, your PR works like a charm (at least on Android, didn't try on iOs). Hopefully it will be merged soon. |
Any movement on this? Or is this plugin abandoned? |
@eaglejs seems abandoned but you can use this npm package if you need the ns-7 version https://www.npmjs.com/package/nativescript-vue-shadow-ns-7 |
Thank you @Upd4ting! Since my app is Android only, I ended up just using the androidElevation attribute/css property.
That gave me the shadows back, only downside is that it does not work on iOS. And you do need a background-color defined. |
Hey all. Sorry for not responding up to this point. Been trying to figure out a way to do this and make sure everything works. However, I created this plugin over a year ago, and have since lost access to a Mac to be able to do any further development and validation that things are working. I'm not actually using Nativescript on anything at the moment due to a job change so that's another issue I have with trying to maintain this. With those two things together, I just haven't done anything with this PR and I apologize for that. It's not fair to all of you who use it. I can go ahead and merge this PR without testing it, but not sure when I will be able to get npm updated. You can still install directly from Github but I know that's a pain. So, the choices are:
Looking for feedback on this. |
Hello @jawa-the-hutt No worries, thanks for your answer! |
feel free to review and accept it