Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify include / exclude precedence #337

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

robw-mercury
Copy link
Contributor

@robw-mercury robw-mercury commented Aug 9, 2024

While reading the docs, I found a sentence that was ambiguous and potentially misleading.

Note: The boundaries/include option has preference over boundaries/ignore. If you define boundaries/include, use boundaries/ignore to ignore subsets of included files.

"boundaries/include has preference" could mean two things:

  1. boundaries/include is applied first, and boundaries/ignore is applied after. boundaries/exclude has precedence.
  2. boundaries/include is preferred. boundaries/include has precedence.

I edited the docs to use the word "precedence", which removes the ambiguousness.

@javierbrea javierbrea changed the base branch from master to release November 4, 2024 17:07
@javierbrea javierbrea merged commit 4e1f23e into javierbrea:release Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants