-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game #3
base: master
Are you sure you want to change the base?
Game #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
на 3 рк договорились сделать поле, по которому бегают колобки. Пока без цветов
|
||
public void move() { | ||
if (currentDirection == Direction.RIGHT) { | ||
currentPosition.setX(currentPosition.getX() + velocity); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
договорились перемещать с использованием времени тика клиента
добавьте ссылку на фронт в описание пр, пожалуйста |
<relativePath/> <!-- lookup parent from repository --> | ||
</parent> | ||
|
||
<properties> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
<java.version>9</java.version> | ||
<java.version>10</java.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
с этим могут возникнуть проблемы на heroku и travic CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ну хоть var заиспользуйте где-нибудь. А то зачем подключали? =(
https://developer.oracle.com/java/jdk-10-local-variable-type-inference
очень нужно починить CI |
Спасибо большое, а то я долго искал, не мог найти как это сделать. Только issuses находил и никакого решения |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
проблему с двойным ходом надо прям очень быстро фиксить
} | ||
|
||
for (GameSession session : gameSessionsController.getGameSessions()) { | ||
clientSnapshotService.processSnapshotsFor(session); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
первое место, где двигаются колобки
if (lobby.isPlaying() && !lobby.isFinished()) { | ||
final GameSession gameSession = lobby.getAssociatedSession(); | ||
|
||
gameSession.runMechanics(frameTime); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
второе место, где двигаются колобки. Одно надо убрать
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Скорее всего вот это, где мы двигаем колобков пропорционально тику механики, что неверно
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Просто раньше в механике колобки двигались по серверному времени и приходили снепшоты только на поворот. Я вот как раз недавно подправил и сейчас движение колобков завязано на снепшотах клиента и вызов механики я удалил.
clientSnapshotService.processSnapshotsFor(session); | ||
} | ||
|
||
//gameTaskScheduler.tick(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
если taskScheduler не тикает, значит он не нужен. Надо удалить
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ок
No description provided.