Skip to content

Commit

Permalink
remove popup if Anki is down
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonwilliams committed Sep 30, 2021
1 parent ba5aa18 commit d9c91f7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to the "anki" extension will be documented in this file.

Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how to structure this file.

## [1.2.5]

- Don't nag if Anki is not running. This reduces annoying pop-ups if user is just looking at a markdown file unrelated to Anki

## [1.2.3]

- Throw an error if the template is not installed correctly, allowing the user to try again.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "anki",
"displayName": "Anki for VSCode",
"description": "Sync notes with your locally running Anki",
"version": "1.2.4",
"version": "1.2.5",
"publisher": "jasew",
"engines": {
"vscode": "^1.47.0"
Expand Down
5 changes: 1 addition & 4 deletions src/initialSetup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,7 @@ export async function initialSetup(ctx: IContext) {
result = await ctx.ankiService.storeMultipleFiles(resources);
disposable.dispose();
} catch (e: any) {
window.showErrorMessage(
"Anki Installation: Unable to update resources on Anki, please make sure Anki is running and try again"
);
getLogger().error(`installation attempt failed: ${e}`);
getLogger().error(`installation attempt failed (Anki most likely not running): ${e}`);
// If any of the above failed we don't want to update the version, meaning it will try again next time the extension has started
return;
}
Expand Down

0 comments on commit d9c91f7

Please sign in to comment.