Update script to allow single platform builds #76 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonacox
commented
Jan 20, 2025
| @@ -31,14 +31,16 @@ alert="\033[0m${red}\033[1m" | |||
| alertdim="\033[0m${red}\033[2m" | |||
|
|
|||
| # Set trap to help debug any build errors | |||
| trap 'echo -e "${alert}** ERROR with Build - Check /tmp/curl*.log${alertdim}"; tail -30 /tmp/curl*.log' INT TERM EXIT | |||
| trap 'echo -e "${alert}** ERROR with Build on line $LINENO ($0) - Check /tmp/curl*.log${alertdim}"; tail -30 /tmp/curl*.log' ERR TERM EXIT | |||
| trap 'exit 1' INT | |||
There was a problem hiding this comment.
Updated traps to catch user cancellation and to provide more details during build errors (line number and file).
jasonacox
commented
Jan 20, 2025
| case "$choice" in | ||
| n|N ) echo "Exiting"; exit 1 ;; | ||
| * ) echo "Continuing..."; echo "" ;; | ||
| esac |
There was a problem hiding this comment.
Added build details (what is being built) and a user confirmation prompt before proceeding. This will help with those accidental builds that step on your working build, or if you didn't specify the right options/versions. Additionally, added a build -y option to auto-yes this prompt:
./build.sh -y
|
Successful test build: https://github.com/jasonacox/Build-OpenSSL-cURL/actions/runs/12873252243/job/35890386014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated build script to allow building for single platform targets: macOS, iOS or tvOS. Specify with
-p macOS. Default build is for "all" as it has been. Added examples apps for tvOS and macOS.References
Closes #77
Closes #76