Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save actual snapshot when encountering an error #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lexanth
Copy link

@lexanth lexanth commented Feb 15, 2021

Fixes #176

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2021

🦋 Changeset detected

Latest commit: 5926801

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cypress-image-snapshot Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lexanth
Copy link
Author

lexanth commented Feb 22, 2021

@jaredpalmer Could you give this a review? It would be really helpful for my team if we could get this in.

@lexanth
Copy link
Author

lexanth commented Mar 18, 2021

@jaredpalmer Hi, any chance we can get this in?

@jsdevtom
Copy link

@jaredpalmer Would you like this "actual" to be optional? The code looks good to me

@himsachan
Copy link

when this changes will be released ?

@shchekoldin
Copy link

This one will be very useful for us. Right now we are applying this patch using post install hook :(

@lexanth
Copy link
Author

lexanth commented Sep 13, 2021

@jaredpalmer would you be interested in giving some other contributors commit rights? There's a bit of low-hanging fruit in existing PRs that would be nice to get merged, I'm guessing you don't have much time for this at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need actual image as a seperate image
4 participants