Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand cypress peer dependency versions #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jdanil
Copy link

@jdanil jdanil commented Feb 4, 2021

Expand cypress peer dependency versions to include v5 and v6.

Fixes #168

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2021

⚠️ No Changeset found

Latest commit: bec2595

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jdanil
Copy link
Author

jdanil commented Feb 15, 2021

@jaredpalmer when you get a chance to review 🙏
Wasn't sure if you preferred caret versions (^) or greater than (>=) to avoid this issue for future major version updates.

@Develliot
Copy link

@jaredpalmer +1 for this

We might have to update this again very soon because Cypress 7 is going to come out soon and we will be 3 major versions behind, it's a dev dependency so it's not the end of the world, it's just nice to not have to have multiple version of cypress installed.

@jdanil
Copy link
Author

jdanil commented Apr 6, 2021

Now that cypress v7 is out, I updated this to a >= check to ensure the new version is included, and any future versions.

@jaredpalmer when you get a chance.

@nischi
Copy link

nischi commented Apr 7, 2021

Please merge :) Need this as well

@Josmithr
Copy link

Josmithr commented May 8, 2021

Any update on this? I would like this change as well.

@pdaether
Copy link

pdaether commented May 18, 2021

I also would vote for changing this. At the moment I need to run npm i with the --force-flag in my project, which is not a very clean way.

@ghost
Copy link

ghost commented Jun 17, 2021

Same as @pdaether .
This is completely ruining npm install 😭
@jaredpalmer Please please please

@rabelloo
Copy link

I would also love to see this merged.

@crosscompile would you be able to help here?
@jaredpalmer seems to be unresponsive for a few months.

@ksmills9
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants