fix: prevent array from creating invalid length (#16)

jaredLunde · Apr 25, 2022 · f26f228 · f26f228
1 parent 0646312
commit f26f228
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/tree/tree.ts b/src/tree/tree.ts
@@ -167,7 +167,7 @@ export class Tree<NodeData = {}> {
     if (nodeToRemoveParent?.nodes) {
       let found = 0;
       const nextNodes: number[] = new Array(
-        nodeToRemoveParent.nodes.length - 1
+        Math.max(nodeToRemoveParent.nodes.length - 1, 0)
       );
 
       for (let i = 0; i < nodeToRemoveParent.nodes.length; i++) {
@@ -205,7 +205,9 @@ export class Tree<NodeData = {}> {
     // Parent may have changed in the meantime
     if (node.parent === initialParent) {
       if (initialParent?.nodes) {
-        const nextNodes: number[] = new Array(initialParent.nodes.length - 1);
+        const nextNodes: number[] = new Array(
+          Math.max(initialParent.nodes.length - 1, 0)
+        );
         let found = 0;
 
         for (let i = 0; i < initialParent.nodes.length; i++) {

diff --git a/src/use-virtualize.ts b/src/use-virtualize.ts
@@ -136,7 +136,7 @@ export function useVirtualize<Meta>(
         Math.ceil((scrollPosition.scrollTop + overscan) / totalNodeHeight)
       );
       const length = stopIndex - index;
-      const children: React.ReactElement[] = new Array(length);
+      const children: React.ReactElement[] = new Array(Math.max(length, 0));
 
       for (; index < stopIndex; index++) {
         const nodeId = visibleNodes[index];