优化代码

januwA · Jul 7, 2019 · fbd4c3d · fbd4c3d
1 parent fa579b6
commit fbd4c3d
Show file tree

Hide file tree

Showing 5 changed files with 74 additions and 19 deletions.
diff --git a/lib/pages/recently_updated/recently_updated_page.dart b/lib/pages/recently_updated/recently_updated_page.dart
@@ -2,6 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter_mobx/flutter_mobx.dart';
 import 'package:flutter_video_app/pages/recently_updated/recently_updated.store.dart';
 import 'package:flutter_video_app/shared/widgets/anime_card.dart';
+import 'package:flutter_video_app/shared/widgets/sliver_loading.dart';
 
 RecentlyUpdatedStore recentlyUpdatedStore = RecentlyUpdatedStore();
 
@@ -34,14 +35,7 @@ class _RecentlyUpdatedPageState extends State<RecentlyUpdatedPage> {
                           AnimeCard(animeData: anime),
                       ],
                     )
-                  : SliverToBoxAdapter(
-                      child: Padding(
-                        padding: const EdgeInsets.all(8.0),
-                        child: Center(
-                          child: CircularProgressIndicator(),
-                        ),
-                      ),
-                    );
+                  : SliverLoading();
             },
           ),
         ],

diff --git a/lib/pages/recommend/recommend_page.dart b/lib/pages/recommend/recommend_page.dart
@@ -2,6 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter_mobx/flutter_mobx.dart';
 import 'package:flutter_video_app/pages/recommend/recommend.store.dart';
 import 'package:flutter_video_app/shared/widgets/anime_card.dart';
+import 'package:flutter_video_app/shared/widgets/sliver_loading.dart';
 
 RecommendStore recommendStore = RecommendStore();
 
@@ -34,14 +35,7 @@ class _RecommendPageState extends State<RecommendPage> {
                           AnimeCard(animeData: anime),
                       ],
                     )
-                  : SliverToBoxAdapter(
-                      child: Padding(
-                        padding: const EdgeInsets.all(8.0),
-                        child: Center(
-                          child: CircularProgressIndicator(),
-                        ),
-                      ),
-                    );
+                  : SliverLoading();
             },
           ),
         ],

diff --git a/lib/shared/widgets/sliver_loading.dart b/lib/shared/widgets/sliver_loading.dart
@@ -0,0 +1,16 @@
+import 'package:flutter/material.dart';
+
+class SliverLoading extends StatelessWidget {
+  @override
+  Widget build(BuildContext context) {
+    double height = MediaQuery.of(context).size.height;
+    return SliverToBoxAdapter(
+      child: Container(
+        height: height,
+        child: Center(
+          child: CircularProgressIndicator(),
+        ),
+      ),
+    );
+  }
+}
diff --git a/lib/store/version/version.service.dart b/lib/store/version/version.service.dart
@@ -19,11 +19,25 @@ abstract class _VersionService with Store {
   @observable
   bool permissisonReady = false;
 
+  @observable
+  Map<String, dynamic> _latestData;
+
+  @action
+  setLatestData(Map<String, dynamic> data) {
+    _latestData = data;
+  }
+
   /// github 上最新版本的数据
+  @computed
   Future<Map<String, dynamic>> get latestData async {
-    var r = await http.get(
-        'https://api.github.com/repos/januwA/flutter_anime_app/releases/latest');
-    return jsonDecode(r.body);
+    if (_latestData == null) {
+      var r = await http.get(
+          'https://api.github.com/repos/januwA/flutter_anime_app/releases/latest');
+      setLatestData(jsonDecode(r.body));
+      return _latestData;
+    } else {
+      return _latestData;
+    }
   }
 
   /// 用户本地版本

diff --git a/lib/store/version/version.service.g.dart b/lib/store/version/version.service.g.dart