Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async, upgrade app packages #23

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mikkelking
Copy link

Summary

  • Upgrade app packages to make it work again
  • Made database calls async, ready for v3

Linked issue(s)

#22

Involved parts of the project

  • app
  • backend

Reproduction

Just run it up

Copy link
Owner

@jankapunkt jankapunkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mikkelking good to see you here, been a long time! Thanks a lot for the update, I got a few comments we should discuss before continuing. Once they are resolved we can move forward.

app/package.json Outdated Show resolved Hide resolved
app/package.json Outdated Show resolved Hide resolved
app/package.json Outdated Show resolved Hide resolved
backend/imports/tasks/methods.js Outdated Show resolved Hide resolved
backend/imports/tasks/methods.js Outdated Show resolved Hide resolved
backend/imports/tasks/methods.js Outdated Show resolved Hide resolved
app/package.json Show resolved Hide resolved
app/package.json Show resolved Hide resolved
@mikkelking
Copy link
Author

@jankapunkt I made changes to remove unnecessary packages. I locked some react-native versions to prevent expo warnings, but this could be short sighted ?

@jankapunkt
Copy link
Owner

@mikkelking would you mind to check the failing tests? The backend lint issues should be fixable using meteor npm run lint:fix and for the tests please make sure your changes did not break existing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants