Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 9 of 21 clojure.string vars #201

Merged
merged 24 commits into from
Feb 25, 2025
Merged

Conversation

frenchy64
Copy link
Contributor

@frenchy64 frenchy64 commented Jan 29, 2025

Implements:

  • clojure.string/blank?
  • clojure.string/capitalize
  • clojure.string/ends-with?
  • clojure.string/escape
  • clojure.string/includes?
  • clojure.string/lower-case
  • clojure.string/reverse
  • clojure.string/starts-with?
  • clojure.string/upper-case

@djblue
Copy link
Contributor

djblue commented Jan 29, 2025

Very cool! If you start looking at regex, I started some of that work here. I'm still looking through various performance characteristic of different regex libraries.

@frenchy64 frenchy64 changed the title WIP: clojure.string Implement 9 of 21 clojure.string vars Feb 5, 2025
@frenchy64 frenchy64 marked this pull request as ready for review February 5, 2025 06:03
@frenchy64 frenchy64 requested review from djblue and jeaye February 5, 2025 06:13
@frenchy64 frenchy64 changed the title Implement 9 of 21 clojure.string vars WIP: Implement 9 of 21 clojure.string vars Feb 8, 2025
@frenchy64 frenchy64 changed the title WIP: Implement 9 of 21 clojure.string vars Implement 9 of 21 clojure.string vars Feb 24, 2025
@frenchy64 frenchy64 requested a review from jeaye February 24, 2025 23:14
@frenchy64 frenchy64 requested review from djblue and removed request for djblue February 25, 2025 00:17
@jeaye jeaye merged commit 6aa330a into jank-lang:main Feb 25, 2025
7 checks passed
@jeaye
Copy link
Member

jeaye commented Feb 25, 2025

Great work, Ambrose! This is a good chunk of clojure.string. 💪

@frenchy64
Copy link
Contributor Author

Hell yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants