chore: correct conversational API request methods with latest cortex update #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barecheck - Code coverage reportTotal: 67.61%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
urmauur
approved these changes
Feb 4, 2025
|
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
louis-menlo
added a commit
that referenced
this pull request
Feb 4, 2025
louis-menlo
added a commit
that referenced
this pull request
Feb 6, 2025
…#4568) # Conflicts: # extensions/inference-cortex-extension/bin/version.txt
louis-menlo
added a commit
that referenced
this pull request
Feb 6, 2025
* chore: correct conversational PATCH methods with latest cortex update (#4568) # Conflicts: # extensions/inference-cortex-extension/bin/version.txt * chore: bump cortex 1.0.9-rc8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR aims to update the cortex latest version to rectify the API convention issue of using the POST method instead of the PATCH method for update endpoints.
There are two conversational endpoints that scoped in the fix:
Modify a thread
jan/extensions/conversational-extension/src/index.ts
Line 66 in 54e04c8
Modify a message
jan/extensions/conversational-extension/src/index.ts
Line 105 in 54e04c8
Fixes Issues
Changes
This pull request includes changes to the
CortexConversationalExtensionclass in theextensions/conversational-extension/src/index.tsfile. The changes update the HTTP method used for modifying threads and messages fromPOSTtoPATCH.Key changes:
modifyThreadmethod to use thePATCHHTTP method instead ofPOSTwhen sending updates to the thread endpoint.modifyMessagemethod to use thePATCHHTTP method instead ofPOSTwhen sending updates to the message endpoint.