fix: PATCH method for Thread and Messages management #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-menlo
approved these changes
Feb 4, 2025
ohaiibuzzle
pushed a commit
to ohaiibuzzle/cortex.cpp
that referenced
this pull request
Feb 9, 2025
Co-authored-by: vansangpfiev <[email protected]>
vansangpfiev
added a commit
that referenced
this pull request
Feb 10, 2025
* feat: AMD hardware API (#1797) * feat: add amd gpu windows * chore: remove unused code * feat: get amd gpus * fix: clean * chore: cleanup * fix: set activate * fix: build windows * feat: linux * fix: add patches * fix: map cuda gpus * fix: build * chore: docs * fix: build * chore: clean up * fix: build * fix: build * chore: pack vulkan windows * chore: vulkan linux --------- Co-authored-by: vansangpfiev <[email protected]> * fix: add cpu usage (#1868) Co-authored-by: vansangpfiev <[email protected]> * fix: PATCH method for Thread and Messages management (#1923) Co-authored-by: vansangpfiev <[email protected]> * fix: ignore compute_cap if not present (#1866) * fix: ignore compute_cap if not present * fix: correct gpu info * fix: remove check for toolkit version --------- Co-authored-by: vansangpfiev <[email protected]> * fix: models.cc: symlinked model deletion shouldn't remove original file (#1918) Co-authored-by: vansangpfiev <[email protected]> --------- Co-authored-by: vansangpfiev <[email protected]> Co-authored-by: OHaiiBuzzle <[email protected]>
vansangpfiev
added a commit
that referenced
this pull request
Feb 10, 2025
* fix: add metadata * fix: add get models by source * fix: metadata json * fix: get downloaded models * fix: add checkedForSyncHubAt to rc * fix: handle hf download by model id * fix: update model when download from model sources * fix: cortexso model download * feat: AMD hardware API (#1797) * feat: add amd gpu windows * chore: remove unused code * feat: get amd gpus * fix: clean * chore: cleanup * fix: set activate * fix: build windows * feat: linux * fix: add patches * fix: map cuda gpus * fix: build * chore: docs * fix: build * chore: clean up * fix: build * fix: build * chore: pack vulkan windows * chore: vulkan linux --------- Co-authored-by: vansangpfiev <[email protected]> * fix: add cpu usage (#1868) Co-authored-by: vansangpfiev <[email protected]> * fix: handle sub-directory HF * fix: add author in response for /models/sources GET * fix: PATCH method for Thread and Messages management (#1923) Co-authored-by: vansangpfiev <[email protected]> --------- Co-authored-by: vansangpfiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes changes to the HTTP methods used in the
MessagesandThreadscontrollers to better align with RESTful principles. The most important changes are:HTTP method updates:
engine/controllers/messages.h: Updated theModifyMessagemethod to use thePatchHTTP method instead ofPost.engine/controllers/threads.h: Updated theModifyThreadmethod to use thePatchHTTP method instead ofPost.Fixes Issues
Self Checklist