fix: add engine in unload model request (#916)

janhq · Jul 25, 2024 · 5caef68 · 5caef68
1 parent bbcd90e
commit 5caef68
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cortex-js/src/domain/abstracts/engine.abstract.ts b/cortex-js/src/domain/abstracts/engine.abstract.ts
@@ -60,5 +60,5 @@ export abstract class EngineExtension extends Extension {
    * Unloads a model from the engine.
    * @param modelId
    */
-  async unloadModel(modelId: string): Promise<void> {}
+  async unloadModel(modelId: string, engine?: string): Promise<void> {}
 }
diff --git a/cortex-js/src/infrastructure/providers/cortex/cortex.provider.ts b/cortex-js/src/infrastructure/providers/cortex/cortex.provider.ts
@@ -93,9 +93,9 @@ export default class CortexProvider extends OAIEngineExtension {
     ).then(); // pipe error or void instead of throwing
   }
 
-  override async unloadModel(modelId: string): Promise<void> {
+  override async unloadModel(modelId: string, engine?: string): Promise<void> {
     return firstValueFrom(
-      this.httpService.post(this.unloadModelUrl, { model: modelId }),
+      this.httpService.post(this.unloadModelUrl, { model: modelId, engine }),
     ).then(); // pipe error or void instead of throwing
   }
 

diff --git a/cortex-js/src/usecases/models/models.usecases.ts b/cortex-js/src/usecases/models/models.usecases.ts
@@ -276,7 +276,7 @@ export class ModelsUsecases {
     this.eventEmitter.emit('model.event', modelEvent);
 
     return engine
-      .unloadModel(modelId)
+      .unloadModel(modelId, model.engine || Engines.llamaCPP)
       .then(() => {
         delete this.activeModelStatuses[modelId];
         const modelEvent: ModelEvent = {