Update CodeQL actions to latest version #1547
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This hasn’t fixed the problem. My apologies. The code quality workflow only runs on PRs so I couldn’t test it beforehand. I’m trying again to find the source of problem. |
|
That does seem odd. At first glance, the changes in this PR look like those described in the blog post. |
|
In a direct message, @sogaiu pointed out that it might be related to github/codeql-action#2701. I’ll wait to see if the update to v2.20.2 fixes it when that’s rolled out (apparently) later this week. |
|
The new version of CodeQL has fixed the problem. I followed the suggestion here and adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub workflow that Janet runs to check code quality began failing with the merge of #1544 on 12 January 2025. This workflow uses version 2 of various CodeQL actions. According to this blog post, these actions were ‘retired’ on 10 January 2025.
This PR changes the version from 2 to 3. This is the latest version at the time of this PR.