Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to dune.3.8 to allow dune to run test partitions concurrently #40

Closed
wants to merge 4 commits into from

Conversation

hhugo
Copy link

@hhugo hhugo commented Mar 2, 2023

This is just a Draft because the two items below need to happen first.

This PR

  1. upgrade the dune lang to 3.8
  2. use ppxlib V2 api
  3. make the ppx compute the partition name if not specified. (requires 2)
  4. teach dune how to list partitions (requires 1)

This change should be enough to have tests run concurrently inside dune when using ppx_inline_test or ppx_expect.

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Mar 3, 2023
@v-gb
Copy link

v-gb commented Mar 16, 2023

Hey! I'll take the ppx change, as that doesn't require a new version of dune.

@v-gb
Copy link

v-gb commented Mar 17, 2023

Actually, can you sign the commits as expected by the DCO check in the "checks" tab?

@hhugo
Copy link
Author

hhugo commented Mar 21, 2023

Rebased and signed commits

@hhugo
Copy link
Author

hhugo commented Mar 21, 2023

The dune PR has been merged. Waiting for the next dune release

@hhugo
Copy link
Author

hhugo commented May 23, 2023

Dune 3.8 is about to be released on opam ocaml/opam-repository#23814

@hhugo hhugo marked this pull request as ready for review May 25, 2023 13:24
@hhugo
Copy link
Author

hhugo commented May 25, 2023

I've rebased the PR

@hhugo
Copy link
Author

hhugo commented Jun 5, 2023

Are there any known blocker for upgrading the dune lang version of Jane Street packages ?

@v-gb
Copy link

v-gb commented Jun 6, 2023

@dkalinichenko-js can we bump the version of dune we require, or is that problematic?

@dkalinichenko-js
Copy link

Paging @ceastlund, but seems fine by me.

@ceastlund
Copy link
Member

No objection from me.

@hhugo
Copy link
Author

hhugo commented Jul 19, 2023

I'm guessing dune files are still generated automatically on your side. If so, any news regarding bumping the dune lang version ?

@hhugo
Copy link
Author

hhugo commented Sep 29, 2023

gentle ping

@dkalinichenko-js
Copy link

Hi! We found that we need to rework our code generator for dune files before we can switch to a recent language version, and it's unclear whether we'll do this in time for the next release. That said, I can manually port those changes to v0.16.1 if needed.

@hhugo
Copy link
Author

hhugo commented Sep 29, 2023

it's unclear whether we'll do this in time for the next release

When do you expect the next release ?

I can manually port those changes to v0.16.1 if needed.

It's going to be annoying if this change is "reverted" at every release. That said, having a minor v0.16 release would immediately benefit all ppx_inline_tests users so I'm all for it.

public-release pushed a commit that referenced this pull request Oct 2, 2023
@dkalinichenko-js
Copy link

When do you expect the next release ?

Around December-January.

I've submitted the release v0.16.1 with your change to the main opam repository. I'll keep this PR around as a reminder for fixing this issue on our side.

@hhugo
Copy link
Author

hhugo commented Apr 13, 2024

Any progress on that front ?

@dkalinichenko-js
Copy link

Hi! The release v0.17 of our libraries will use Dune 3.11 and is under our review right now.

@hhugo
Copy link
Author

hhugo commented Jun 1, 2024

Thanks.

@hhugo hhugo closed this Jun 1, 2024
@hhugo hhugo deleted the dune-3.8 branch June 1, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants