-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to dune.3.8 to allow dune to run test partitions concurrently #40
Conversation
Hey! I'll take the ppx change, as that doesn't require a new version of dune. |
Actually, can you sign the commits as expected by the DCO check in the "checks" tab? |
Rebased and signed commits |
The dune PR has been merged. Waiting for the next dune release |
Dune 3.8 is about to be released on opam ocaml/opam-repository#23814 |
I've rebased the PR |
Are there any known blocker for upgrading the dune lang version of Jane Street packages ? |
@dkalinichenko-js can we bump the version of dune we require, or is that problematic? |
Paging @ceastlund, but seems fine by me. |
No objection from me. |
I'm guessing dune files are still generated automatically on your side. If so, any news regarding bumping the dune lang version ? |
gentle ping |
Hi! We found that we need to rework our code generator for dune files before we can switch to a recent language version, and it's unclear whether we'll do this in time for the next release. That said, I can manually port those changes to v0.16.1 if needed. |
When do you expect the next release ?
It's going to be annoying if this change is "reverted" at every release. That said, having a minor v0.16 release would immediately benefit all ppx_inline_tests users so I'm all for it. |
Around December-January. I've submitted the release v0.16.1 with your change to the main opam repository. I'll keep this PR around as a reminder for fixing this issue on our side. |
Any progress on that front ? |
Hi! The release v0.17 of our libraries will use Dune 3.11 and is under our review right now. |
Thanks. |
This is just a Draft because the two items below need to happen first.
This PR
This change should be enough to have tests run concurrently inside dune when using ppx_inline_test or ppx_expect.