Default modalities and simple modal modules #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Del Vecchio <[email protected]>
Signed-off-by: Thomas Del Vecchio <[email protected]>
Signed-off-by: Thomas Del Vecchio <[email protected]>
Signed-off-by: Thomas Del Vecchio <[email protected]>
Signed-off-by: Thomas Del Vecchio <[email protected]>
tdelvecchio-jsc
force-pushed
the
modal-modules-simple
branch
from
4210772 to
4b1dfb3
Compare
dvulakh
requested changes
Jan 29, 2025
Comment on lines
+1
to
+3
| @@ moda1 moda2 | ||
|
|
||
| (** cmt *) |
There was a problem hiding this comment.
Would it be easy to keep the doc comment at the beginnig of the file? It's common to have a large documentation comment that gives a high-level description of the interface at the top of an mli, and I think it would be better not to have to push it down.
There was a problem hiding this comment.
That unfortunately is not currently syntactically valid, and I had to do a hack to even get this to work. See diff at https://github.com/janestreet/ocamlformat/pull/97/files#diff-cae07aad219a479660ff7234c7aab435a1cd1791e66cf33d3763f37c12a5f3acR674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables adding
@@ portableat the top of an mli file (and at the beginning ofsig ... endblocks), as well as marking module declarations with modes:This is enough to get us started adding portability to our code, though there is more syntax to implement in the future.