Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions when updating #37

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fix permissions when updating #37

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7a9f166
fix permissions when updating
bjfultn Oct 4, 2019
2423669
Update README.md
bjfultn Oct 4, 2019
357694a
Update README.md
bjfultn Oct 4, 2019
ed18fa1
Update README.md
bjfultn Oct 4, 2019
1c77f2f
narrowing permissions change
bjfultn Oct 8, 2019
4d141ca
Merge branch 'master' of https://github.com/bjfultn/docker-dropbox
bjfultn Oct 8, 2019
02dfe59
upgrade to stretch + fix libatomic1 issue
adamkdean Nov 15, 2019
673c1b8
update README
adamkdean Nov 15, 2019
c39ca18
update README again
adamkdean Nov 15, 2019
0214396
fixing conflicts
bjfultn Nov 15, 2019
941a6a2
Merge branch 'adamkdean-master'
bjfultn Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ This repository provides the [janeczku/dropbox](https://registry.hub.docker.com/

## Usage examples

### Optional first step
(shouldn't be neccesary unless you need to make changes to the `Dockerfile` or the `run` script).

# from the docker-dropbox directory
docker build . --tag janeczku/dropbox

### Quickstart

docker run -d --restart=always --name=dropbox janeczku/dropbox
Expand Down
1 change: 1 addition & 0 deletions run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ if [[ -z "$DBOX_SKIP_UPDATE" ]]; then
fi
fi

chmod -R a+rx /opt/dropbox/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is overly broad, and will set the executable bit on many files that aren't executable. I used

chmod a+rx /opt/dropbox/dropbox-lnx*/*.so

Copy link
Author

@bjfultn bjfultn Oct 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changed as suggested.

echo "Starting dropboxd ($(cat /opt/dropbox/VERSION))..."
umask 002
exec su dropbox -s /bin/bash -c /opt/dropbox/dropboxd