Update test_course.py to add tests for zero students #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added tests for contains and remove where there are zero students in the course
fixed a typo CS161 -> CS101
twentylemon
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Tests in this file are grouped by the list cardinality. Empty list tests are at the top of the file; where there is already a test for removing from the empty list.
Please move the contains test to be with the other empty list tests, and remove the duplicate test.
Removed redundant test for remove, and moved the contains test to be properly grouped by course cardinality. Also changed the name of the test to match the naming convention
twentylemon
reviewed
Nov 29, 2024
fixed indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added tests for course.contains() and course.remove() where there are zero students in the course