Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧑‍💻 🐛 Country Catalogue Assignment --- Remove mention of area in add docstring #604

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

jameshughes89
Copy link
Owner

What

Remove the mention of the area parameter in the add method in the CountryCatalogue class.

Why

It's not actually a parameter for the method.

Testing

YOLO

Additional Notes

  1. I believe this is from a previous version of the assignment where the add method created the Country object and then appended.
  2. Oddly, this issue did not exist in the assignments repo.

@jameshughes89 jameshughes89 added the typo/bug 🐛 Bug in Code or Typo label Nov 30, 2023
@jameshughes89
Copy link
Owner Author

I changed out the ipynb file by downloading from colab to eliminate any issues with the pycharm editing of the ipynb file.

Also, looks like the ipynb file keeps track of how many times a cell was run, which is neat. Those fields in the file are changed here but should not have any functional implication.

@jameshughes89 jameshughes89 merged commit f1ba0a2 into main Nov 30, 2023
3 checks passed
@jameshughes89 jameshughes89 deleted the assignment-country_catalogue-remove_area branch November 30, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo/bug 🐛 Bug in Code or Typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants