Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript rewrite, new options, improved workflows & whatnot #30
base: typescript-rewrite
Are you sure you want to change the base?
TypeScript rewrite, new options, improved workflows & whatnot #30
Changes from 20 commits
f947e7d
aedc573
0dd6db5
db3369b
6625b8a
5f7a63a
f61d037
b59ba64
c740c63
74eca0f
a73e419
cc8ea04
983567e
65fe788
f5a1b73
35baa4e
ad6b90e
2f8b17a
b8af06f
86ea2e5
4ee59a6
72abe63
9c6632d
b2ed64b
3eec2c7
cc4a7e9
f387559
2ad1698
89301e2
fd9cb99
21796ff
3052d7d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the motivation behind introducing this input param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one?
NO_COMMIT
orLINES
?NO_COMMIT
: if someone wants to do some other edit to the README they can do it and then push all the changes in a single commit.LINES
: they can select the number of lines from the workflowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're checking to see if there is any difference between the content enclosed within the respective comments and the latest data being pulled. Any change made to other sections of the
README
doesn't affect this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesgeorge007 That's not the issue: I may want to do some other changes to the README and then commit everything together, instead of having multiple commits.