fixes bug in participation network for loop #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a duplicate set of network stats for the prior IOPAC port group when a port group has no fish tickets in a given year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug that made some IOPAC ports have duplicate rows in the NetworkStats and NodeStats output files in some years. This turned out to be because the next port on the list for that year had no fish tickets in that year, so the
g_netstatsandg_nodestatstemp dataframes weren't overwritten in the next iteration of the for loop and produced duplicate rows in themystats3andmystats4objects. I fixed it by making sure that the temp dataframes were appended tomystats3andmystats4within theelsestatement for port-year combinations that produced a valid igraph object, not outside it.