Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JIFFY-293] Make locale settings configurable in Jiffy #294

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

jama5262
Copy link
Owner

What does this PR do?

Make locale settings configurable in Jiffy. Such as

  1. Make start of week, relative date time and ordinals

Issue Reference

Fixes #293

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance change (non-breaking change such as upgrading a dependency, refactoring, or making a lint fix)
  • Documentation update
  • Breaking change (a fix or feature that would cause existing functionality to change)

Screenshots

If applicable, add screenshots to help explain your problem.

Checklist

  • Wrote additional tests, if needed
  • All tests have passed, you can find the scripts from the ./bin folder
  • I have updated the documentation accordingly, if needed.

Additional Information

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 93.02326% with 60 lines in your changes missing coverage. Please review.

Project coverage is 95.79%. Comparing base (8a94744) to head (1d50c84).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/src/locale/relative_date_time.dart 91.97% 57 Missing ⚠️
lib/src/global/global_start_of_week.dart 80.00% 2 Missing ⚠️
lib/src/jiffy.dart 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   96.46%   95.79%   -0.67%     
==========================================
  Files          36       15      -21     
  Lines        1611     1452     -159     
==========================================
- Hits         1554     1391     -163     
- Misses         57       61       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jama5262 jama5262 merged commit 37cc090 into master Feb 12, 2025
3 of 5 checks passed
@jama5262 jama5262 deleted the JIFFY-293-make-locales-settings-configurable branch February 12, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functionality to dynamically add custom locale
1 participant