Clarifications about using EL in property values #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly document that EL expressions are expected also in annotations nested in the main annotations (
OpenIdAuthenticationMechanismDefinitionrefers to some other nested annotations). Even though some of the annotations contain XExpression attibutes for non-String attributes, which implicitly suggests that ELs are also supported in String attributes, it was nowhere explicitly stated.I also reworded the description about the implicit
baseURLvariable in theOpenIdAuthenticationMechanismDefinition.redirectURIattribute to explicitly state that this is a regular EL implicit variable and no "special" expression. This should be similar to the implicitselfvariable in theRememberMe.cookieMaxAgeSecondsExpressionattribute.Some of this should be covered with additional tests because there's currently only a single test that covers ELs in the OpenID annotation. I've raised issues #223, #224 to write the tests. I can write them later when I have more time, either within this PR or in a separate PR.