Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

position and rotation special cases added to SceneNode.setPropertyVal… #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

position and rotation special cases added to SceneNode.setPropertyVal… #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c0482a
position and rotation special cases added to SceneNode.setPropertyVal…
evallsg Jul 2, 2021
f994375
search_bones_in_parent added to options (not harcoded) for creting Sk…
evallsg Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/sceneNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,13 @@ SceneNode.prototype.setPropertyValueFromPath = function( path, value, offset )
{
case "matrix": target = this.transform; break;
case "position":
target = this.transform;
varname = path[offset];
break;
case "rotation":
target = this.transform;
varname = path[offset];
break;
case "x":
case "y":
case "z":
Expand Down Expand Up @@ -1254,8 +1260,9 @@ SceneNode.prototype.addMeshComponents = function( mesh_id, extra_info )
//skinning
if(mesh && mesh.bones)
{
compo = new ONE.Components.SkinDeformer({ search_bones_in_parent: false }); //search_bones_in_parent is false because usually DAEs come that way
this.addComponent( compo );
var options = { search_bones_in_parent: mesh.search_bones_in_parent || false }; //search_bones_in_parent is false because usually DAEs come that way (but not for glTF)
compo = new ONE.Components.SkinDeformer(options);
this.addComponent( compo );
}

//morph targets
Expand Down