Checks and installs pyusb and confirms compatibility with Latitude 7270 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2022 16:46
Also: - Added a link to pip pyusb site - Added Latitude 7270 to the list of tested laptops
jacekkow
requested changes
Mar 23, 2022
|
Thank you for taking the time to give such good feedbac. I'll have some time to make those little changes soon. |
- usb device funtions now on a separate file - nfc main function catches import exception by importing separate file - no longer attempts to install pyusb
kalpo
commented
Mar 31, 2022
jacekkow
reviewed
Mar 31, 2022
nfc.py
Outdated
| from usbhandler import UsbDeviceFinder | ||
| except ImportError as e: | ||
| if e.name == 'usb': | ||
| print("'usb' module note found!.\nThe 'pyusb' library is required.") |
There was a problem hiding this comment.
- Use logger (level - error) or print to stderr (
print('...', file=sys.stderr)). - If module other than usb cannot be imported, you'd not print anything - please add
elseclause for such case, i.e.:
else:
raise
There was a problem hiding this comment.
Darn, you are right! Will do that now.
|
One thing left and I'm ready to merge it. |
|
This last commit prints to sderr for any inport error. And only specifically tells the user that pyusb is required when it is that library that we they are missing. Happy to delete that bit if you think it is a bit too much info. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull would:
Feel free to edit all you want. Thanks again for taking the time to make this project happen