Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Fix Null Reference Exceptions #93

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix Null Reference Exceptions #93

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8208802
Fix 2 Null Reference Exceptions
Saibamen Oct 2, 2022
037960c
Print variable name in debug if value was found
Saibamen Oct 2, 2022
ac02f33
Fix more NREs and add more info for warning logs
Saibamen Oct 2, 2022
4130ad0
Print UpdateStatus key value
Saibamen Oct 2, 2022
8a9ce3a
No refs returned is not a warning
Saibamen Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions Tasks/common/GitRefCreator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export abstract class GitRefCreator {

let artifactData: IArtifactData[] = await this.getAllGitArtifacts(bldapi, gitapi);

if (artifactData.length === 0) {
if (!artifactData || artifactData.length === 0) {
tl.warning("No TfsGit artifacts found.");
}

Expand Down Expand Up @@ -96,7 +96,7 @@ export abstract class GitRefCreator {
}

if (variableInfo.value !== "TfsGit" && variableInfo.value !== "Git") {
tl.debug(`Matching variable: ${variableInfo.name}, but artifact type: ${variableInfo.value}`);
tl.debug(`Matching variable: ${variableInfo.name}, but artifact type: ${variableInfo.value}`);
continue;
}

Expand Down Expand Up @@ -171,7 +171,7 @@ export abstract class GitRefCreator {
tl.debug(`Attempting to determine which commit was last. Prev: ${prev.commit} Current: ${current.commit} for repository: ${prev.repositoryId}`);

const commits: giti.GitCommitRef[] = await gitapi.getCommitsBatch(search, prev.repositoryId);
if (commits.length !== 2) {
if (!commits || commits.length !== 2) {
tl.setResult(tl.TaskResult.Failed, `Cannot resolve difference most recent between two commits: ${prev.commit} ${current.commit}`);
return artifacts;
}
Expand Down Expand Up @@ -225,15 +225,15 @@ export abstract class GitRefCreator {
let repositoryid: string = tl.getVariable(repositoryidVariable);

if (repositoryid) {
tl.debug(`Got repositoryid from variable: ${repositoryid}`);
tl.debug(`Got repositoryid from variable (${repositoryidVariable}): ${repositoryid}`);
return repositoryid;
}

// YAML
repositoryidVariable = `release.artifacts.${name}.repository.id`;
repositoryid = tl.getVariable(repositoryidVariable);
if (repositoryid) {
tl.debug(`Got repositoryid from YAML variable: ${repositoryid}`);
tl.debug(`Got repositoryid from YAML variable (${repositoryidVariable}): ${repositoryid}`);
return repositoryid;
}

Expand All @@ -247,7 +247,7 @@ export abstract class GitRefCreator {

if (buildid) {
let build: bldi.Build = await bldapi.getBuild(Number(buildid));
tl.debug(`Got repositoryid from build: ${build.repository.id}`);
tl.debug(`Got repositoryid from build (${buildidVariable}): ${build.repository.id}`);
return build.repository.id;
}

Expand All @@ -256,7 +256,7 @@ export abstract class GitRefCreator {

if (buildid) {
let build: bldi.Build = await bldapi.getBuild(Number(buildid));
tl.debug(`Got repositoryid from YAML build: ${build.repository.id}`);
tl.debug(`Got repositoryid from YAML build (${buildidVariable}): ${build.repository.id}`);
return build.repository.id;
}

Expand All @@ -266,7 +266,7 @@ export abstract class GitRefCreator {
if (buildid) {
let build: bldi.Build = await bldapi.getBuild(Number(buildid));
if (build) {
tl.debug(`Got repositoryid from YAML pipeline resource: ${build.repository.id}`);
tl.debug(`Got repositoryid from YAML pipeline resource (${buildidVariable}): ${build.repository.id}`);
return build.repository.id;
}
else {
Expand Down Expand Up @@ -296,6 +296,12 @@ export abstract class GitRefCreator {
tl.debug(`Updating ref: ${localRefName}`);

let updateResult: giti.GitRefUpdateResult = await this.updateRef(artifact, localRefName, gitapi);

if (updateResult === null) {
tl.setResult(tl.TaskResult.Failed, `Unable to create ref: ${this.refName} RepositoryId: ${artifact.repositoryId} Old Commit: ${artifact.oldCommitId} New Commit: ${artifact.commit}`);
return;
}

if (updateResult.success) {
tl.debug("Ref updated!");
return;
Expand All @@ -311,18 +317,21 @@ export abstract class GitRefCreator {
case giti.GitRefUpdateStatus.CreateTagPermissionRequired:
tl.error(`${this.permissionTemplate}Create Tag`);
break;
default:
tl.error(`Unknown UpdateStatus: ${updateResult.updateStatus} (${giti.GitRefUpdateStatus[updateResult.updateStatus]})`);
break;
}

tl.error(`If you need to change permissions see: _admin/_versioncontrol?_a=security&repositoryId=${artifact.repositoryId}`);

tl.setResult(tl.TaskResult.Failed, `Unable to create ref: ${this.refName} UpdateStatus: ${updateResult.updateStatus} RepositoryId: ${updateResult.repositoryId} Old Commit: ${updateResult.oldObjectId} New Commit: ${updateResult.newObjectId}`);
tl.setResult(tl.TaskResult.Failed, `Unable to create ref: ${this.refName} UpdateStatus: ${updateResult.updateStatus} (${giti.GitRefUpdateStatus[updateResult.updateStatus]}) RepositoryId: ${updateResult.repositoryId} Old Commit: ${updateResult.oldObjectId} New Commit: ${updateResult.newObjectId}`);
}
private async populateExistingRefCommit(artifact: IArtifactData, refName: string, gitapi: git.IGitApi) {
tl.debug(`Getting refs for: '${refName}' with repositoryId: '${artifact.repositoryId}'`);

let refs: giti.GitRef[] = await gitapi.getRefs(artifact.repositoryId, null, refName);
if (refs == null) {
tl.debug(`No refs returned`);
if (refs == null || Object.keys(refs).length === 0) {
tl.debug(`No refs returned for '${refName}'`);
return;
}

Expand All @@ -346,7 +355,7 @@ export abstract class GitRefCreator {
let refArray: giti.GitRefUpdate[] = [ref];
let updateRefsResult: giti.GitRefUpdateResult[] = await gitapi.updateRefs(refArray, artifact.repositoryId);
if (updateRefsResult == null || updateRefsResult.length === 0) {
tl.warning(`No update result returned from updateRefs`);
tl.warning(`No update result returned from updateRefs for '${refName}'`);
return null;
}

Expand Down