Adding Region as configurable parameter #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tack environments while still defaulting to "RegionOne"
On CoreOS it is not possible to create the socket with the 'root' group, it has to be 'docker'. Reference: docker/go-plugins-helpers#38
|
Additionally I've added SocketGroup as configurable parameter, on CoreOS machines it's not possible to set up the socket using the 'root' user group. Without setting this to 'docker', the plugin will fail to start, see for instance docker/go-plugins-helpers#38 as a reference. With this additional configurable parameter, the plugin is now working as expected on a CoreOS host on the OVH public cloud. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support using the driver on OpenStack environments with multiple regions (or a non-default name) I've added 'Region' as configurable parameter. I'm not completely sure if we'd want to default to "RegionOne" as value but I've added it for compatibility just in case. Using these changes it's now possible to use the driver on the OpenStack platform of OVH.com.
Finally I've also updated the example configs to include double quotes around the attribute names as those are required by the JSON parser.
I think these changes should be safe to be merged in but let me know if you see any issues!
Thanks,