Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Refatoração do controller de usuário #70

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Refactor: Refatoração do controller de usuário #70

merged 4 commits into from
Mar 7, 2024

Conversation

JonasFortes12
Copy link
Collaborator

@JonasFortes12 JonasFortes12 commented Mar 6, 2024 •
edited
Loading

Proposta deste PR

  • Este PR tem o objetivo de refatorar algumas partes da implementação que necessitam de melhoras.

Impactos deste PR

  • Adiciona anotações de teste em alguns métodos de teste que estavam sem essa anotação.
  • Troca os lançamentos de erros comuns por lançamentos de erros que a API pode tratar.
  • Realoca a verificação de username duplicado que estava na classe controller para a classe service.

Evidências de testes

Todos os testes passam:
image

@JonasFortes12 JonasFortes12 marked this pull request as ready for review March 6, 2024 22:31
@JonasFortes12 JonasFortes12 self-assigned this Mar 6, 2024
williambrunos
williambrunos approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@williambrunos williambrunos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

yannluk4
yannluk4 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@yannluk4 yannluk4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

izaiasmachado
izaiasmachado approved these changes Mar 7, 2024
View reviewed changes
Copy link
Owner

@izaiasmachado izaiasmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que beleza, LGTM!

@JonasFortes12 JonasFortes12 merged commit 162d5e8 into main Mar 7, 2024
4 checks passed
@JonasFortes12 JonasFortes12 deleted the refact/refatoracao-usuario branch March 7, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaiasmachado izaiasmachado izaiasmachado approved these changes

@williambrunos williambrunos williambrunos approved these changes

@yannluk4 yannluk4 yannluk4 approved these changes

Assignees

@JonasFortes12 JonasFortes12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JonasFortes12 @izaiasmachado @williambrunos @yannluk4