Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: return stock dto #55

Merged
merged 22 commits into from
Mar 6, 2024
Merged

refactor: return stock dto #55

merged 22 commits into from
Mar 6, 2024

Conversation

izaiasmachado
Copy link
Owner

@izaiasmachado izaiasmachado commented Mar 4, 2024

Issue

É importante que uma camada de serviço (StockService) sempre retorne um DTO (ResponseStockDTO). Além disso, é importante que a camada de controle (StockController) não conheça o modelo de negócio (Stock).

Proposta deste PR

  • Refatorar partes da camada de serviço que não retornam um DTO

Impactos deste PR

  • Refatorações no StockController e StockService
  • Refatorações no PortfolioService
  • Atualização dos testes existentes para novo retorno dos métodos

Evidências de teste

Screenshot 2024-03-04 at 20 46 28

@izaiasmachado izaiasmachado changed the base branch from main to chore/add-jacoco-coverage March 5, 2024 00:51
@izaiasmachado izaiasmachado changed the base branch from chore/add-jacoco-coverage to main March 5, 2024 00:52
@izaiasmachado izaiasmachado marked this pull request as ready for review March 5, 2024 01:04
Copy link
Collaborator

@williambrunos williambrunos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parece-me bom para mim

@izaiasmachado izaiasmachado merged commit aba7f8e into main Mar 6, 2024
4 checks passed
@izaiasmachado izaiasmachado deleted the refactor/stock branch March 6, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants