Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: routes for buy and sell stocks #54

Merged
merged 12 commits into from
Mar 6, 2024
Merged

feat: routes for buy and sell stocks #54

merged 12 commits into from
Mar 6, 2024

Conversation

JonasFortes12
Copy link
Collaborator

@JonasFortes12 JonasFortes12 commented Mar 4, 2024 •
edited
Loading

Issue

De acordo com a Issue #53, é preciso implementar rotas para comprar e vender ações.

Proposta deste PR

  • Criar uma rota para comprar um ou vários títulos de uma ação.
  • Criar uma rota para vender um ou vários títulos de uma ação.

Impactos deste PR

  • Criação da rota para comprar um ou vários títulos de uma ação.
  • Criação da rota para vender um ou vários títulos de uma ação pertencente ao portfolio do usuário.
  • Implementação de testes de integração para testar essas duas rotas.

Evidências de teste

image

@JonasFortes12 JonasFortes12 changed the title Buy and Sell Stocks feat: routes for buy and sell stocks Mar 5, 2024
izaiasmachado
izaiasmachado approved these changes Mar 6, 2024
View reviewed changes
Copy link
Owner

@izaiasmachado izaiasmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Testado localmente

@williambrunos williambrunos self-requested a review March 6, 2024 00:41
williambrunos
williambrunos approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@williambrunos williambrunos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Testei localmente, sucesso

@JonasFortes12 JonasFortes12 linked an issue Mar 6, 2024 that may be closed by this pull request
BDD Feature: comprar e vender ações #53
Closed
@JonasFortes12 JonasFortes12 self-assigned this Mar 6, 2024
@JonasFortes12 JonasFortes12 marked this pull request as ready for review March 6, 2024 19:52
@JonasFortes12 JonasFortes12 merged commit df5f1cd into main Mar 6, 2024
4 checks passed
@JonasFortes12 JonasFortes12 deleted the feature/buy-sell-stocks branch March 6, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaiasmachado izaiasmachado izaiasmachado approved these changes

@williambrunos williambrunos williambrunos approved these changes

Assignees

@JonasFortes12 JonasFortes12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BDD Feature: comprar e vender ações
3 participants
@JonasFortes12 @izaiasmachado @williambrunos