Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add withdraw and deposit #44

Merged
merged 20 commits into from
Mar 5, 2024
Merged

feat: add withdraw and deposit #44

merged 20 commits into from
Mar 5, 2024

Conversation

yannluk4
Copy link
Collaborator

@yannluk4 yannluk4 commented Mar 1, 2024 •
edited by izaiasmachado
Loading

Issue

Conforme solicitado, pelo descritivo do projeto, foi necessário implementar uma conta com possibilidade de depósitos e saques.

image

Proposta deste PR

  • Operações de depósito e saque na conta do usuário

Impactos deste PR

  • Implementada a rota GET /account/deposit?amount=
  • Implementada a rota GET /account/withdraw?amount=

Evidências de teste

Screenshot 2024-03-04 at 11 08 42 Screenshot 2024-03-04 at 11 09 00 Screenshot 2024-03-04 at 11 15 23 Screenshot 2024-03-04 at 12 43 32

@yannluk4 yannluk4 marked this pull request as ready for review March 1, 2024 22:32
@yannluk4 yannluk4 marked this pull request as draft March 1, 2024 22:35
@yannluk4 yannluk4 marked this pull request as ready for review March 4, 2024 18:31
@yannluk4 yannluk4 self-assigned this Mar 4, 2024
izaiasmachado
izaiasmachado approved these changes Mar 4, 2024
View reviewed changes
Copy link
Owner

@izaiasmachado izaiasmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Testado localmente

@izaiasmachado izaiasmachado changed the title feat: add withdraw feat: add withdraw and deposit Mar 5, 2024
@yannluk4 yannluk4 merged commit a2f0614 into main Mar 5, 2024
4 checks passed
@yannluk4 yannluk4 deleted the feature/deposit-and-withdraw branch March 5, 2024 00:41
@yannluk4 yannluk4 linked an issue Mar 6, 2024 that may be closed by this pull request
BDD Feature: implementação dos métodos de saque e deposito. #59
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaiasmachado izaiasmachado izaiasmachado approved these changes

@williambrunos williambrunos williambrunos approved these changes

@JonasFortes12 JonasFortes12 Awaiting requested review from JonasFortes12

Assignees

@yannluk4 yannluk4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BDD Feature: implementação dos métodos de saque e deposito.
3 participants
@yannluk4 @izaiasmachado @williambrunos