Fully qualify module names #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
This pull request improves the module graph representation by using the full module path as its identifier, a shorter name is used for rendering it.
📄 Motivation and Context
Previously, the module graph would use only the module name, which could lead to conflicts, especially in projects with complex structures and repeated modules names.
By fully qualifying module names in the graph, we eliminate ambiguity and improve the utility of the generated diagrams.
🧪 How Has This Been Tested?
Unit tests, integration tests
📦 Types of changes
✅ Checklist