Add circular dependency to ProjectParserRootModulesTest for testing

iurysza · May 4, 2024 · b83690e · b83690e
1 parent 176b179
commit b83690e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/...ld/modulegraph/src/test/java/dev/iurysouza/modulegraph/ModuleGraphPluginFunctionalTest.kt b/...ld/modulegraph/src/test/java/dev/iurysouza/modulegraph/ModuleGraphPluginFunctionalTest.kt
@@ -431,6 +431,7 @@ class ModuleGraphPluginFunctionalTest {
                     java
                 }
                 dependencies {
+                    // Cheeky circular dependency
                     implementation(project(":example"))
                 }
             """.trimIndent(),

diff --git a/...build/modulegraph/src/test/java/dev/iurysouza/modulegraph/ProjectParserRootModulesTest.kt b/...build/modulegraph/src/test/java/dev/iurysouza/modulegraph/ProjectParserRootModulesTest.kt
@@ -22,6 +22,7 @@ internal class ProjectParserRootModulesTest {
         ModuleToDeps.featAData,
         ModuleToDeps.commonData,
         ModuleToDeps.coreNetworking,
+        ModuleToDeps.coreUtil,
     )
 
     private val projectQuerier = object : ProjectQuerier {
@@ -64,6 +65,7 @@ internal class ProjectParserRootModulesTest {
             ModuleToDeps.featAData,
             ModuleToDeps.commonData,
             ModuleToDeps.coreNetworking,
+            ModuleToDeps.coreUtil,
         )
         val actualGraph = ProjectParser.parseProjectGraph(
             allProjectPaths = Project.allPaths,
@@ -83,6 +85,8 @@ internal class ProjectParserRootModulesTest {
             ModuleToDeps.featAUi,
             ModuleToDeps.commonComponent,
             ModuleToDeps.coreUi,
+            ModuleToDeps.coreUtil,
+            ModuleToDeps.coreNetworking,
         )
         val actualGraph = ProjectParser.parseProjectGraph(
             allProjectPaths = Project.allPaths,
@@ -102,6 +106,7 @@ internal class ProjectParserRootModulesTest {
             ModuleToDeps.featAData,
             ModuleToDeps.commonData,
             ModuleToDeps.coreNetworking,
+            ModuleToDeps.coreUtil,
         )
         val actualGraph = ProjectParser.parseProjectGraph(
             allProjectPaths = Project.allPaths,
@@ -152,7 +157,9 @@ private data class ProjectAndDeps(val path: ProjectPath, val deps: List<ProjectP
 private object Project {
     val coreUtil = ProjectAndDeps(
         MockProjectPath.coreUtil,
-        emptyList(),
+        // We create a circular dependency between util and networking
+        // In a real Gradle project this is illegal, but we should still be able to render it.
+        listOf(MockProjectPath.coreNetworking),
     )
     val coreNetworking = ProjectAndDeps(
         MockProjectPath.coreNetworking,
@@ -224,6 +231,9 @@ private object ModuleToDeps {
     val coreNetworking = createDefaultModuleSource(MockProjectPath.coreNetworking) to listOf(
         createDefaultModuleTarget(MockProjectPath.coreUtil),
     )
+    val coreUtil = createDefaultModuleSource(MockProjectPath.coreUtil) to listOf(
+        createDefaultModuleTarget(MockProjectPath.coreNetworking),
+    )
 
     private fun createDefaultModuleSource(path: String) = Module(
         path = path,