Fix type id slug parsing

itsmeow · Mar 6, 2020 · fac6cf8 · fac6cf8
1 parent e2d12a9
commit fac6cf8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -1,5 +1,5 @@
 name: Test
-#
+
 on:
   push:
     paths:

diff --git a/curseforge-upload.js b/curseforge-upload.js
@@ -14,7 +14,10 @@ async function getGameVersions(token, endpoint) {
             } else {
                 if(valStr.includes(':')) {
                     let valStrSp = valStr.split(':');
-                    gameVersionNames[valStrSp[0]] = valStrSp[1];
+                    if(valStrSp.length != 2) {
+                        core.setFailed("Invalid game version type id pair: " + valStr + " - Valid Format: typeid:versionid");
+                    }
+                    gameVersionNames[valStrSp[1]] = valStrSp[0];
                 } else {
                     gameVersionNames[valStr] = "blank";
                 }
@@ -44,7 +47,7 @@ async function getGameVersions(token, endpoint) {
         const versionTypeData = Object.values(gameVersionNames).filter((v,i,a) => v != "blank").length > 0 ? JSON.parse(await requestPromise(optionsTypes)) : [];
 
         const filteredVersions = versionData.filter(function(value, index, array) {
-            
+
             let typeId = gameVersionNames.hasOwnProperty(value.name) ? gameVersionNames[value.name] : (gameVersionNames.hasOwnProperty(value.slug) ? gameVersionNames[value.slug] : "");
             if(typeId != null && typeId != "blank" && typeId != "") {
                 if(isID(typeId)) {
-Original file line number
+Diff line change
@@ -1,5 +1,5 @@
     name: Test
-    #
     on:
       push:
         paths:
@@ Expand Down @@