Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(studio): handle unexpected exceptions in updates thread #864

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

shcheklein
Copy link
Member

@shcheklein shcheklein commented Feb 4, 2025

Continuation of #860

Fixes #858

We catch properly unexpected exceptions in Studio updates thread and continue consuming from the queue (to make it empty so join below doesn't hang).

TODO:

  • Add test

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@shcheklein shcheklein self-assigned this Feb 4, 2025
@shcheklein shcheklein requested a review from skshetry February 4, 2025 03:33
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.34%. Comparing base (4309f21) to head (af72738).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/dvclive/live.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
- Coverage   95.35%   95.34%   -0.01%     
==========================================
  Files          55       55              
  Lines        3979     3999      +20     
  Branches      309      311       +2     
==========================================
+ Hits         3794     3813      +19     
  Misses        138      138              
- Partials       47       48       +1     
Flag Coverage Δ
dvclive 95.34% <95.45%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shcheklein shcheklein force-pushed the fix-858/race-condition-studio-update-2 branch from 8e4ff04 to af72738 Compare February 6, 2025 03:18
@shcheklein shcheklein merged commit 3dac488 into main Feb 6, 2025
16 checks passed
@shcheklein shcheklein deleted the fix-858/race-condition-studio-update-2 branch February 6, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exp hangs forever when logging images
2 participants