Kakao&Naver OAuth #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzjinwook
commented
Aug 25, 2023
| //response_type: 인증 과정에 대한 구분값. code로 값이 고정돼 있습니다. | ||
| //redirect_uri: 네이버 로그인 인증의 결과를 전달받을 콜백 URL(URL 인코딩). 애플리케이션을 등록할 때 Callback URL에 설정한 정보입니다. | ||
| //state: 애플리케이션이 생성한 상태 토큰 | ||
| private final static String REDIRECT_URI = "http://localhost:8080/hyunique/navercallback"; |
There was a problem hiding this comment.
url 형태 좀 손보면 좋을 것 같아요
차라리 naver/callback
|
|
||
| // 로그인 성공 후 유저 정보 페이지(임시) 이동 | ||
| @RequestMapping(value = "/userInfo", method = RequestMethod.GET) | ||
| public String example(HttpSession session) { |
Comment on lines
+92
to
+93
| System.out.println(nickname); | ||
| System.out.println(id); |
| } | ||
|
|
||
| // 세션에 id저장 | ||
| private void setSessionId(HttpSession session, String id, String type) { |
There was a problem hiding this comment.
HttpSession 쓸건지 @SessionAttribute 쓸건 지 확실하게 정하고 갑시다
| @Service | ||
| public class OAuthService { | ||
|
|
||
| @Value("${key.KAKAO}") |
There was a problem hiding this comment.
굿 properties 활용
| sb.append("grant_type=authorization_code"); | ||
|
|
||
| sb.append("&client_id="+kakaoApiKey); //발급 api키 | ||
| sb.append("&redirect_uri=http://localhost:8080/hyunique/KakaoLogin"); // 본인이 설정한 주소 |
There was a problem hiding this comment.
localhost:8080 -> 배포 url로 교체 필요
| // 유저 기본정보 가져오기 | ||
| @GetMapping("{userId}") | ||
| public String getUserInfoAndFollowerCount(HttpSession session, Model model) { | ||
| String sessionId = (String) session.getAttribute("sessionId"); // 세션에서 아이디 가져오기 |
There was a problem hiding this comment.
사용자 로그인 시 세션에 sessionId 로 userId가 저장됨
Comment on lines
+54
to
+56
| @GetMapping("update") | ||
| public String userUpdatePage(HttpServletRequest request, Model model) { | ||
| UserVO user = (UserVO) request.getSession().getAttribute("user"); // 세션에서 UserVO 가져오기 |
There was a problem hiding this comment.
그냥 Session으로 처리 가능, 굳이 request 객체 받을 필요 없음
Comment on lines
+17
to
+20
| @Autowired | ||
| private UserMapper userMapper; | ||
|
|
||
| @Autowired |
There was a problem hiding this comment.
Autowired 두번 괜찮나요?
Comment on lines
+20
to
+22
| hy_user.user_id as userId, | ||
| hy_user.user_img as | ||
| userImg, |
There was a problem hiding this comment.
현재 스네이크 케이스에서 카멜 케이스로 자동 매핑해주는 기능 넣어져있어서 이렇게 할 필요 없어용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제목 - 주요 기능/버그/수정 사항
📕 제목
📗 작업 내용
📘 PR 특이 사항