[FE] 街の領域に色を付けるように #608
Merged
[FE] 街の領域に色を付けるように #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@narirou @imamiya-masaki レビューお願いいたします。 |
popunbom
force-pushed
the
frontend/decolate-city-color
branch
from
b196bc2 to
dcb7533
Compare
popunbom
force-pushed
the
frontend/decolate-city-color
branch
from
dcb7533 to
4b09ca2
Compare
|
@popunbom
|
narirou
reviewed
Dec 4, 2024
frontend/tailwind.config.ts
Outdated
| @@ -3,4 +3,5 @@ import type { Config } from "tailwindcss"; | |||
| export default { | |||
| content: ["./app/**/{**,.client,.server}/**/*.{js,jsx,ts,tsx}"], | |||
| plugins: [], | |||
| safelist: [{ pattern: /bg-.+-600/ }, { pattern: /border-.+-500/ }], | |||
There was a problem hiding this comment.
色指定があるので、styleプロパティでやってtailwindでの対応は実施しないようにお願いします
narirou
reviewed
Dec 4, 2024
| @@ -282,7 +282,7 @@ const TownLayer = memo(function TownLayer() { | |||
| > | |||
| <div | |||
| role="presentation" | |||
| className="absolute rounded-full bg-neutral-100 bg-opacity-40 border-2 border-neutral-200" | |||
| className={`absolute rounded-full bg-neutral-300 bg-opacity-40 border-4 border-${color}-500`} | |||
There was a problem hiding this comment.
ここも可能であればbgは100でお願いしたいです
初期の見た目がグレーになってしまうためmm
narirou
reviewed
Dec 4, 2024
| @@ -11,6 +11,7 @@ type TextProps = PropsWithChildren<{ | |||
| size?: Size; | |||
| variant?: Variant; | |||
| className?: string; | |||
| style?: React.CSSProperties; | |||
|
一旦マージして私の方で揃えてみます! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates: #241
こちらに対応しました